Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): deprecate NodeJS pre 18.* #1163

Merged
merged 1 commit into from
Dec 19, 2023
Merged

chore(deps): deprecate NodeJS pre 18.* #1163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ It offers high-level object-oriented abstractions to define render farm infrastr
using the power of Python and Typescript.

The RFDK is available in:
- Javascript, Typescript ([Node.js >= 18.0.0](https://nodejs.org/download/release/latest-v18.x/))
- Javascript, Typescript ([Node.js >= 18.0.0](https://nodejs.org/download/release/latest-v18.x/) officially supported, [Node.js >= 14.15.0](https://nodejs.org/download/release/latest-v14.x/) unofficially supported)
- We recommend using an [Active LTS Release](https://nodejs.org/en/about/releases/)
- Python ([Python >= 3.6](https://www.python.org/downloads/))

Expand Down
2 changes: 1 addition & 1 deletion integ/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,6 @@
"constructs": "^10.0.0"
},
"engines": {
"node": ">= 18.0.0"
"node": ">= 14.15.0"
}
}
2 changes: 1 addition & 1 deletion lambda-layers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"watch": "tsc -w"
},
"engines": {
"node": ">= 18.0.0"
"node": ">= 14.15.0"
},
"stability": "stable",
"maturity": "stable",
Expand Down
4 changes: 2 additions & 2 deletions packages/aws-rfdk/docs/upgrade/upgrading-1.3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Updating Node.js

Node 14 is End of Life and RFDK >= 1.3.x no longer supports it. Node.js 18.0.0 is the minimum version
that RFDK now supports.
Node 14 is End of Life and RFDK >= 1.3.x no longer officially supports it. Node.js 18.0.0 is now
the minimum officially supported version that RFDK now supports.

You can follow our [installation guide](CONTRIBUTING.md#installing-nodejs) for Node.js to upgrade to the latest version.
6 changes: 6 additions & 0 deletions packages/aws-rfdk/lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,9 @@

export * from './core';
export * as deadline from './deadline';

// Emit a warning for NodeJS versions earlier than 18.x
const version = process.versions.node.split('.').map(parseInt);
if (version[0] < 18) {
process.emitWarning(`RFDK officially supports NodeJS 18 or greater, but got ${process.versions.node}`);
}
2 changes: 1 addition & 1 deletion packages/aws-rfdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
"constructs": "^10.0.0"
},
"engines": {
"node": ">= 18.0.0"
"node": ">= 14.15.0"
},
"stability": "stable",
"maturity": "stable"
Expand Down
2 changes: 1 addition & 1 deletion tools/pkglint/lib/rules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ export class MustHaveNodeEnginesDeclaration extends ValidationRule {
public readonly name = 'package-info/engines';

public validate(pkg: PackageJson): void {
expectJSON(this.name, pkg, 'engines.node', '>= 18.0.0');
expectJSON(this.name, pkg, 'engines.node', '>= 14.15.0');
}
}

Expand Down