Skip to content

Commit

Permalink
refactor: Add reason for skipped tests
Browse files Browse the repository at this point in the history
  • Loading branch information
dscpinheiro committed Nov 21, 2024
1 parent 5aee938 commit 042cf27
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion sdk/test/IntegrationTests/Tests/General.cs
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ public void TestManualClockCorrection()
// By default it only tests a small subset of services.
[TestMethod]
[TestCategory("General")]
[Ignore]
[Ignore("Skipping flaky test while design for clock skew behavior is defined")]
public void TestClockSkewCorrection()
{
VerifyClockSkewSetting();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,10 @@ protected override CredentialsRefreshState GenerateNewCredentials()
}
}

// [Fact]
// This is commented out because netstandard uses xunit which runs tests in parallel.
// This is ignored because netstandard uses xunit which runs tests in parallel.
// When this test is run in parallel with other tests it causes them to fail b/c it changes
// the clockskew while those are running.
[Fact(Skip = "Skipping flaky test while design for clock skew behavior is defined")]
public void TestManualClockCorrection()
{
TestClients(TestServiceCallForManualClockCorrection);
Expand All @@ -144,10 +144,10 @@ public void TestManualClockCorrection()
// This test verifies that all service clients are able to
// correctly handle clock skew errors.
// By default it only tests a small subset of services.
// This is commented out because netstandard uses xunit which runs tests in parallel.
// This is ignored because netstandard uses xunit which runs tests in parallel.
// When this test is run in parallel with other tests it causes them to fail b/c it changes
// the clockskew while those are running.
// [Fact]
[Fact(Skip = "Skipping flaky test while design for clock skew behavior is defined")]
public void TestClockSkewCorrection()
{
TestClients(TestServiceCallForClockSkew);
Expand Down

0 comments on commit 042cf27

Please sign in to comment.