Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Tags and TransitiveTagKeys in AssumeRoleAWSCredentialsOptions #1829

Closed
2 tasks done
JeffAshton opened this issue Apr 12, 2021 · 4 comments
Closed
2 tasks done
Assignees
Labels
credentials cross-sdk-parity feature-request A feature should be added or improved. p1 This is a high priority issue queued

Comments

@JeffAshton
Copy link
Contributor

JeffAshton commented Apr 12, 2021

Would like to see Tags and TransitiveTagKeys added to Amazon.Runtime.AssumeRoleAWSCredentialsOptions. Session tags allow fine grained control access to resources. It would be amazing if AssumeRoleAWSCredentials supported this.

Proposed Solution


This is a 🚀 Feature Request

@JeffAshton JeffAshton added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 12, 2021
@JeffAshton JeffAshton changed the title Specify Tags in AssumeRoleAWSCredentialsOptions Specify Tags and TransitiveTagKeys in AssumeRoleAWSCredentialsOptions Apr 15, 2021
@JeffAshton
Copy link
Contributor Author

Just a thought, but adding an equivalent replacement for AssumeRoleAWSCredentials that lives in the Security Token assembly might be more ideal. That way it can reuse the Tag model class, and the assembly dependency is explicit instead of implicit. It's annoying when this fails at runtime because you forgot to reference the Security Token package as well.

@ashishdhingra
Copy link
Contributor

ICoreAmazonSTS.CredentialsFromAssumeRoleAuthentication extension method is currently only used internally in AssumeRoleAWSCredentials.GenerateNewCredentials(). AmazonSecurityTokenServiceClient supports AssumeRoleAsync() which has support for tags (as specified by AWS Security Token Service -> AssumeRole service API. May be adding support for tags and transitive keys in the extension method could be helpful for user. Not sure if this should be added in AssumeRoleAWSCredentialsOptions as it might be a breaking change. Needs review with the team.

@ashishdhingra ashishdhingra added needs-review and removed needs-triage This issue or PR still needs to be triaged. labels Jan 25, 2022
@ik130 ik130 added cross-sdk-parity p1 This is a high priority issue and removed needs-review labels Dec 1, 2022
@ashishdhingra ashishdhingra self-assigned this Jun 14, 2024
@ashishdhingra
Copy link
Contributor

ashishdhingra commented Jun 19, 2024

AWSSDK.SecurityToken 3.7.300.107 added support for Tags and TransitiveTagKeys in ICoreAmazonSTS.CredentialsFromAssumeRoleAuthentication() method.

Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
credentials cross-sdk-parity feature-request A feature should be added or improved. p1 This is a high priority issue queued
Projects
None yet
Development

No branches or pull requests

3 participants