Do not create strings just for comparison

[paulomorgado]

Describe the feature

Amazon.Runtime.Internal.Marshaller.PreInvoke has this code:

#if NETSTANDARD
            var method = requestContext.Request.HttpMethod.ToUpperInvariant();
#else
            var method = requestContext.Request.HttpMethod.ToUpper(CultureInfo.InvariantCulture);
#endif
            if (method != "GET" && method != "DELETE" && method != "HEAD")

method is only used for comparison and can potentially be a newly allocated string.

Use Case

Creating objects that do not need to be created, not only uses memory and CPU to create them, but also causes GC work.

Proposed Solution

Use Equals(String, String, StringComparison) with StringComparison.OrdinalIgnoreCase, instead:

            var method = requestContext.Request.HttpMethod;
            if (!"GET".Equals(method, StringComparison.OrdinalIgnoreCase)
                && "DELETE".Equals(method, StringComparison.OrdinalIgnoreCase)
                && "HEAD".Equals(method, StringComparison.OrdinalIgnoreCase))

Ordinal ignore-case comparison can also be used in dictionaries, avoiding creating creating new strings just for index lookup.

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

AWS .NET SDK and/or Package version used

AWSSDK.KeyManagementService 3.7.300.52

Targeted .NET Platform

.NET 8

Operating System and version

Windows and Linux

[ashishdhingra]

@paulomorgado Good morning. Thanks for opening the issue. Could you please point me to the exact location of code which you are referring to? I'm unable to find the code you are referring to here.

Thanks,
Ashish

[ashovlin]

We refactored that code that was inspecting the HTTP verbs recently via #3338.

Though there are likely other occurrences of creating strings for comparisons that we can take a look at, if you have others that are in a hot spot?

[paulomorgado]

@paulomorgado Good morning. Thanks for opening the issue. Could you please point me to the exact location of code which you are referring to? I'm unable to find the code you are referring to here.

Thanks, Ashish

According to @ashovlin, this code has been replaced.

[github-actions]

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.