Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch .net 472 version of SDK to use HttpClient instead of HttpWebRequest #3449

Closed
2 tasks
MichaelSabin-Citrix opened this issue Aug 21, 2024 · 4 comments
Closed
2 tasks
Labels
feature-request A feature should be added or improved. module/sdk-core needs-review p2 This is a standard priority issue v4

Comments

@MichaelSabin-Citrix
Copy link

Describe the feature

With the upgrade to 4.0.0, I would like to recommend that the SDK use a consistent HTTP Pipeline for .Net Framework and Standard. This will ease compatibility testing for customers who want to upgrade their existing app to .net standard

Use Case

Compatibility between .Net Framework / Standard, also less testing since consistent SDK is used

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

AWS SDK 4.0.0-preview

Targeted .NET Platform

.Net Framework 4.7.2

Operating System and version

Windows 11, Windows Server 2022

@MichaelSabin-Citrix MichaelSabin-Citrix added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 21, 2024
@bhoradc bhoradc added module/sdk-core p2 This is a standard priority issue needs-review v4 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 21, 2024
@normj
Copy link
Member

normj commented Aug 21, 2024

@MichaelSabin-Citrix I would love to use HttpClient for both .NET Framework and .NET Core instead of using HttpWebRequest for .NET Framework. It would make our lives easier maintaining the SDK. We tried that in the past but since HttpClient is really a wrapper around HttpWebRequest in .NET Framework with limitations the performance was terrible when used at scale. We got a lot of customer issues with their application performance degrading so we had to revert the change and is why today we use HttpWebRequest for .NET Framework and HttpClient for .NET Core.

@MichaelSabin-Citrix
Copy link
Author

MichaelSabin-Citrix commented Aug 21, 2024

Ok thanks. Yeah HttpClientHandler uses HttpWebRequest underneath the covers for .NET Framework...

@normj
Copy link
Member

normj commented Aug 23, 2024

Closing because this is not something we are going to do for performance reasons.

@normj normj closed this as completed Aug 23, 2024
Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/sdk-core needs-review p2 This is a standard priority issue v4
Projects
None yet
Development

No branches or pull requests

3 participants