Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding TryAddDefaultAWSOptions to AWSSDK.Extensions.NETCore.Setup #3481

Closed
1 of 2 tasks
paulomorgado opened this issue Sep 20, 2024 · 4 comments · Fixed by #3483
Closed
1 of 2 tasks

Consider adding TryAddDefaultAWSOptions to AWSSDK.Extensions.NETCore.Setup #3481

paulomorgado opened this issue Sep 20, 2024 · 4 comments · Fixed by #3483
Labels
feature-request A feature should be added or improved. module/sdk-custom p2 This is a standard priority issue s Effort estimation: small

Comments

@paulomorgado
Copy link

Describe the feature

Microsoft.Extensions.DependencyInjection.ServiceCollectionExtensions.AddDefaultAWSOptions always registers AWSOptions even if there was a previous registration.

There should be a TryAddDefaultAWSOptions to register only if it hasn't been registered before, like TryAddAWSService.

Use Case

configuration.TryAddDefaultAWSOptions();

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

AWSSDK.Extensions.NETCore.Setup version 3.7.301

Targeted .NET Platform

.NET 8

Operating System and version

Window, Linux, etc.

@paulomorgado paulomorgado added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 20, 2024
@bhoradc bhoradc added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Sep 20, 2024
@ashishdhingra
Copy link
Contributor

@paulomorgado Thanks for submitting feature request. Feel free to contribute PR that could be implemented by the team.

@ashishdhingra ashishdhingra added s Effort estimation: small and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Sep 20, 2024
@ashishdhingra ashishdhingra removed their assignment Sep 20, 2024
@paulomorgado
Copy link
Author

paulomorgado commented Sep 20, 2024

@ashishdhingra

@paulomorgado Thanks for submitting feature request. Feel free to contribute PR that could be implemented by the team.

Done: #3483

@dscpinheiro
Copy link
Contributor

Your PR has been merged, and will be included in the next preview release of the SDK.

Thanks again for the contribution!

Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/sdk-custom p2 This is a standard priority issue s Effort estimation: small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants