Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Missing ctor for AmazonSimpleEmailServiceV2Client #3519

Closed
2 tasks
lonix1 opened this issue Oct 18, 2024 · 2 comments
Closed
2 tasks

[feat] Missing ctor for AmazonSimpleEmailServiceV2Client #3519

lonix1 opened this issue Oct 18, 2024 · 2 comments
Labels
feature-request A feature should be added or improved. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@lonix1
Copy link

lonix1 commented Oct 18, 2024

Describe the feature

Add a constructor to AmazonSimpleEmailServiceV2Client which takes:

  • credentials
  • region
  • config

Use Case

That class has numerous ctors but none allow setting all the above, and the properties are readonly so cannot be set after instantiation.

(I know the SDK will try default files and env vars, but we are not using those; we use a secrets management system, so must specify the values programmatically.)

Proposed Solution

Either one of these would be fine:

public AmazonSimpleEmailServiceV2Client(
  AWSCredentials credentials, 
  RegionEndpoint region, 
  AmazonSimpleEmailServiceV2Config clientConfig)

or

public AmazonSimpleEmailServiceV2Client(
  string awsAccessKeyId, 
  string awsSecretAccessKey, 
  RegionEndpoint region, 
  AmazonSimpleEmailServiceV2Config clientConfig)

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

AWSSDK.SimpleEmailV2
3.7.403.1

Targeted .NET Platform

.NET 8

Operating System and version

linux

@lonix1 lonix1 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2024
@dscpinheiro
Copy link
Contributor

You can set the region endpoint in the AmazonSimpleEmailServiceV2Config class, like this:

// Retrieved from your secrets management system.
var accessKey = "...";
var secretKey = "...";

var ses = new AmazonSimpleEmailServiceV2Client(accessKey, secretKey, new AmazonSimpleEmailServiceV2Config
{
    RegionEndpoint = RegionEndpoint.USWest2
});

Would that be an option for you?

@dscpinheiro dscpinheiro added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2024
@lonix1 lonix1 closed this as completed Oct 18, 2024
Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants