Exception in ErrorHandler.ProcessException() #858

xakep139 · 2018-02-06T10:18:02Z

If ErrorHandler get an exception of type System.Exception there will be a System.ArgumentNullException with message:

Value cannot be null.
Parameter name: key

Here's the stacktrace:

   at System.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Collections.Generic.Dictionary`2.FindEntry(TKey key)
   at System.Collections.Generic.Dictionary`2.TryGetValue(TKey key, TValue& value)
   at Amazon.Runtime.Internal.ErrorHandler.ProcessException(IExecutionContext executionContext, Exception exception) in E:\JenkinsWorkspaces\v3-trebuchet-release\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\ErrorHandler\ErrorHandler.cs:line 200
   at Amazon.Runtime.Internal.ErrorHandler.<InvokeAsync>d__5`1.MoveNext() in E:\JenkinsWorkspaces\v3-trebuchet-release\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\ErrorHandler\ErrorHandler.cs:line 104
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Amazon.Runtime.Internal.CallbackHandler.<InvokeAsync>d__9`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Amazon.Runtime.Internal.CredentialsRetriever.<InvokeAsync>d__7`1.MoveNext() in E:\JenkinsWorkspaces\v3-trebuchet-release\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\Handlers\CredentialsRetriever.cs:line 98
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Amazon.Runtime.Internal.RetryHandler.<InvokeAsync>d__10`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Amazon.Runtime.Internal.RetryHandler.<InvokeAsync>d__10`1.MoveNext() in E:\JenkinsWorkspaces\v3-trebuchet-release\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\RetryHandler\RetryHandler.cs:line 153
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Amazon.Runtime.Internal.CallbackHandler.<InvokeAsync>d__9`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Amazon.Runtime.Internal.CallbackHandler.<InvokeAsync>d__9`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Amazon.S3.Internal.AmazonS3ExceptionHandler.<InvokeAsync>d__1`1.MoveNext() in E:\JenkinsWorkspaces\v3-trebuchet-release\AWSDotNetPublic\sdk\src\Services\S3\Custom\Internal\AmazonS3ExceptionHandler.cs:line 62
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Amazon.Runtime.Internal.ErrorCallbackHandler.<InvokeAsync>d__5`1.MoveNext() in E:\JenkinsWorkspaces\v3-trebuchet-release\AWSDotNetPublic\sdk\src\Core\Amazon.Runtime\Pipeline\Handlers\ErrorCallbackHandler.cs:line 58
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Amazon.Runtime.Internal.MetricsHandler.<InvokeAsync>d__1`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at DemoS3.Program.<WritingAnObject>d__2.MoveNext() in C:\Users\n.balabaev\Documents\Visual Studio 2017\Projects\DemoS3\Program.cs:line 43

Expected Behavior

Get original exception from ErrorHandler

Current Behavior

Possible Solution

Fix loop logic in ErrorHandler.ProcessException() if exception has type System.Exception

Steps to Reproduce (for bugs)

I've created a repro https://github.com/xakep139/DemoS3. If you replace Exception with any of it subclass (here https://github.com/xakep139/DemoS3/blob/master/BrokenStream.cs#L14), the exception thrown at ErrorHandler.ProcessException() (https://github.com/aws/aws-sdk-net/blob/master/sdk/src/Core/Amazon.Runtime/Pipeline/ErrorHandler/ErrorHandler.cs#L187) will be correct.

Context

Your Environment

AWSSDK.Core version used: 3.3.21.6
Service assembly and version used: AWSSDK.S3 version 3.3.17
Operating System and version: Windows 10 Enterprise 1709 (16299.192)
Visual Studio version: Microsoft Visual Studio Professional 2017 Version 15.5.5
Targeted .NET platform: .NET Core 2.0

.NET Core Info

.NET Core version used for development: 2.0.5
.NET Core version installed in the environment where application runs: 2.0.5
Output of dotnet --info:

.NET Command Line Tools (2.1.4)

Product Information:
 Version:            2.1.4
 Commit SHA-1 hash:  5e8add2190

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.16299
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.4\

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.5
  Build    : 17373eb129b3b05aa18ece963f8795d65ef8ea54

Contents of project.json/project.csproj: https://github.com/xakep139/DemoS3/blob/master/DemoS3.csproj

The text was updated successfully, but these errors were encountered:

github-actions · 2021-10-16T00:08:17Z

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

xakep139 · 2021-10-16T09:13:14Z

@sstevenkang any chance this could be fixed?

github-actions · 2022-10-17T00:22:16Z

We have noticed this issue has not received attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.

xakep139 · 2022-10-17T07:21:51Z

@ashishdhingra do you have any estimations when this issue will be picked up for fixing?

cschulznethaus · 2023-11-22T07:05:35Z

Stumbled on the same issue. I guess ErrorHandler.ProcessExceptionAsync() does not work well, when the exception that is handled is already of type Exception.

ashishdhingra · 2024-07-23T21:28:43Z

Reproducible using code below:
BrokenStream.cs

namespace ConsoleTest
{
    public class BrokenStream : Stream
    {
        public override void Flush()
        {
        }

        public override int Read(byte[] buffer, int offset, int count)
        {
            throw new Exception("Oooops!");
        }

        public override long Seek(long offset, SeekOrigin origin)
        {
            throw new NotSupportedException();
        }

        public override void SetLength(long value)
        {
            throw new NotSupportedException();
        }

        public override void Write(byte[] buffer, int offset, int count)
        {
            throw new NotSupportedException();
        }

        public override bool CanRead => true;
        public override bool CanSeek => false;
        public override bool CanWrite => false;
        public override long Length => 123;
        public override long Position { get; set; }
    }
}

Program.cs

using Amazon.Runtime;
using Amazon.S3.Model;
using Amazon.S3;
using ConsoleTest;

const string BucketName = "somebucket";

using (var client = new AmazonS3Client())
{
    using (var myBrokenStream = new BrokenStream())
    {
        await WritingAnObject(client, myBrokenStream);
    }
}

static async Task WritingAnObject(IAmazonS3 client, Stream inputStream)
{
    try
    {
        var request = new PutObjectRequest
        {
            InputStream = inputStream,
            BucketName = BucketName,
            CannedACL = S3CannedACL.PublicRead,
            Key = "1/temp.txt"
        };

        await client.PutObjectAsync(request);
    }
    catch (Exception ex)
    {
        Console.WriteLine(ex);
    }
}

ashishdhingra · 2024-07-29T21:29:01Z

Fix has been released in AWSSDK.Core 3.7.400.1

github-actions · 2024-07-29T21:30:49Z

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

sstevenkang self-assigned this Feb 19, 2018

klaytaybai added the bug This issue is a bug. label Nov 18, 2019

klaytaybai unassigned sstevenkang Nov 18, 2019

ashishdhingra added needs-reproduction This issue needs reproduction. B module/sdk-core and removed needs-reproduction This issue needs reproduction. labels Oct 15, 2020

github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Oct 16, 2021

github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Oct 17, 2021

github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Oct 17, 2022

github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Oct 18, 2022

ashishdhingra added p2 This is a standard priority issue queued and removed B labels Nov 2, 2022

ashishdhingra self-assigned this Jul 23, 2024

ashishdhingra mentioned this issue Jul 23, 2024

Fixes the loop logic in ErrorHandler.ProcessException() and ErrorHandler.ProcessExceptionAsync() in case the initial exception is of type System.Exception. #3398

Merged

10 tasks

ashishdhingra closed this as completed Jul 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exception in ErrorHandler.ProcessException() #858

Exception in ErrorHandler.ProcessException() #858

xakep139 commented Feb 6, 2018 •

edited

Loading

github-actions bot commented Oct 16, 2021

xakep139 commented Oct 16, 2021

github-actions bot commented Oct 17, 2022

xakep139 commented Oct 17, 2022

cschulznethaus commented Nov 22, 2023

ashishdhingra commented Jul 23, 2024

ashishdhingra commented Jul 29, 2024

github-actions bot commented Jul 29, 2024

Exception in ErrorHandler.ProcessException() #858

Exception in ErrorHandler.ProcessException() #858

Comments

xakep139 commented Feb 6, 2018 • edited Loading

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

.NET Core Info

github-actions bot commented Oct 16, 2021

xakep139 commented Oct 16, 2021

github-actions bot commented Oct 17, 2022

xakep139 commented Oct 17, 2022

cschulznethaus commented Nov 22, 2023

ashishdhingra commented Jul 23, 2024

ashishdhingra commented Jul 29, 2024

github-actions bot commented Jul 29, 2024

xakep139 commented Feb 6, 2018 •

edited

Loading