Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CreateSigner from serviceClient and requests with authtype #3548

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Remove CreateSigner from serviceClient and requests with authtype #3548

merged 2 commits into from
Nov 19, 2024

Conversation

muhammad-othman
Copy link
Member

@muhammad-othman muhammad-othman commented Nov 12, 2024 •
edited
Loading

Description

  • Removed the creation of the Signer property and the logic to create the instance for it in ServiceClients and Requests with AuthType.
  • Updated the serviceClient generator to include all the services otherwise we will have compilation errors, but only commited AutoScaling service for now to avoid huge merge conflicts later.
  • Renamed credentials constructorInput in model customizations to DefaultAWSCredentials.
  • Marked FallbackCredentialsFactory as deprecated and removed it from ServiceClient extensions.
  • Refactored the other usages of FallbackCredentialsFactory to useDefaultIdentityResolverConfiguration.

Motivation and Context

  • DOTNET-7538
  • DOTNET-7649

@96malhar 96malhar requested a review from normj November 12, 2024 18:27
@muhammad-othman muhammad-othman merged commit f0c3a29 into sra-identity-auth Nov 19, 2024
1 check passed
@muhammad-othman muhammad-othman deleted the muhamoth/DOTNET-7538-remove-CreateSigner branch November 19, 2024 15:07
muhammad-othman added a commit that referenced this pull request Nov 25, 2024
@muhammad-othman
Remove CreateSigner from serviceClient and requests with authtype (#3548
f679d71 
)

* Remove CreateSigner from serviceClient and requests with authtype

* Mark fallback credentials factory as deprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscpinheiro dscpinheiro dscpinheiro approved these changes

@normj normj normj approved these changes

Assignees
No one assigned
Labels
SRA v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muhammad-othman @normj @dscpinheiro