-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Labels
enhancementNew feature or requestNew feature or request
Description
If the secret is not on AWS Secrets Manager the client will throw a ResourceNotFoundException
that will be wrapped in SecretCacheObject.__refresh
I think to wrap ResourceNotFoundException
is not good practice: because after the client application has no way to understand that something is wrong in the configuration of Aws SM, and if you have a hook it will be triggered anyway even if an exception occurred and the value is None.
[the implementation of SecretCacheHook
will receive cached_obj = None
in the get method]
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request