From ef9231da894356d3170a58909bdb3421d1cbfa01 Mon Sep 17 00:00:00 2001
From: Ting Cheng <tincheng@amazon.com>
Date: Fri, 26 Jul 2024 12:44:22 -0700
Subject: [PATCH 1/3] Add Unknown option for buildSystem and buildCommand

---
 telemetry/definitions/commonDefinitions.json | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json
index 5b5bb8b7..5e8f8173 100644
--- a/telemetry/definitions/commonDefinitions.json
+++ b/telemetry/definitions/commonDefinitions.json
@@ -289,7 +289,8 @@
                 "gradlew.bat",
                 "gradlew",
                 "gradle",
-                "IDEBundledGradle"
+                "IDEBundledGradle",
+                "Unknown"
             ]
         },
         {
@@ -298,7 +299,8 @@
             "description": "Type of build system",
             "allowedValues": [
                 "Maven",
-                "Gradle"
+                "Gradle",
+                "Unknown"
             ]
         },
         {
@@ -3882,7 +3884,7 @@
         {
             "name": "codeTransform_logGeneralError",
             "passive": true,
-            "description": "Deprecated - avoid logging every service call",
+            "description": "Emit general error that occurred during the transformation.",
             "metadata": [
                 {
                     "type": "codeTransformApiErrorMessage",

From 122e4f37917f837cfa7d1ee2d57267bb485b74cc Mon Sep 17 00:00:00 2001
From: Ting Cheng <tincheng@amazon.com>
Date: Fri, 26 Jul 2024 12:50:58 -0700
Subject: [PATCH 2/3] Make buildSystem and buildCommand optional in metrics

---
 telemetry/definitions/commonDefinitions.json | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json
index 5e8f8173..2224d2f0 100644
--- a/telemetry/definitions/commonDefinitions.json
+++ b/telemetry/definitions/commonDefinitions.json
@@ -290,7 +290,7 @@
                 "gradlew",
                 "gradle",
                 "IDEBundledGradle",
-                "Unknown"
+                "unknown"
             ]
         },
         {
@@ -300,7 +300,7 @@
             "allowedValues": [
                 "Maven",
                 "Gradle",
-                "Unknown"
+                "unknown"
             ]
         },
         {
@@ -3799,7 +3799,7 @@
             "metadata" : [
                 {
                     "type": "codeTransformBuildCommand",
-                    "required": true
+                    "required": false
                 },
                 {
                     "type": "codeTransformSessionId",
@@ -4059,7 +4059,7 @@
                 },
                 {
                     "type": "codeTransformBuildSystem",
-                    "required": true
+                    "required": false
                 },
                 {
                     "type": "codeTransformLocalJavaVersion",

From 9473e05f88fbd87f1a191309031b2803604af407 Mon Sep 17 00:00:00 2001
From: Ting Cheng <tincheng@amazon.com>
Date: Fri, 26 Jul 2024 15:12:54 -0700
Subject: [PATCH 3/3] revert description change for logGeneralError

---
 telemetry/definitions/commonDefinitions.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/telemetry/definitions/commonDefinitions.json b/telemetry/definitions/commonDefinitions.json
index 2224d2f0..3eb54d4c 100644
--- a/telemetry/definitions/commonDefinitions.json
+++ b/telemetry/definitions/commonDefinitions.json
@@ -3884,7 +3884,7 @@
         {
             "name": "codeTransform_logGeneralError",
             "passive": true,
-            "description": "Emit general error that occurred during the transformation.",
+            "description": "Deprecated - avoid logging every service call",
             "metadata": [
                 {
                     "type": "codeTransformApiErrorMessage",