chore(bindings): move tokio examples to dedicated folder #4954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #4909 , #4910 , #4911
Description of changes:
All of the rust-sec issues are for transitive dependencies of one of our dev dependencies,
clap. This can be solved by upgradingclapto4.0, but that breaks our MSRV.So instead we are moving the examples out of the main
s2n-tls-tokiocrate, and we are moving it into the dedicatedrust-examplesfolder. This required two things.rust-examples/client-hello-config-resolution/certstorust-examples/certs. This allows all of the examples to use the same certs folder (or reuse certs)s2n-tls-tokioexample binaries to a dedicatedtokio-server-clientexample.Testing:
I manually ran the examples to confirm that they were functioning as expected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.