Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom domain name optional #17

Open
lmammino opened this issue Oct 10, 2022 · 1 comment
Open

Make custom domain name optional #17

lmammino opened this issue Oct 10, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lmammino
Copy link
Member

Right now it is necessary to have a custom domain which makes the first setup unnecessarily complicated and it makes it hard for people to just try to install weshare.

It might be good to figure out how to use AWS-generated domain names (through API Gateway URLs) by default.

This requires a bit of research and there might be some significant pain points:

  • We currently assume there's only 1 base URL and we rely on that to build the other URLs (${base}/auth and ${base}/share). If we cannot rely on a custom domain we would need to either merge the auth and the backend stack to have the same API Gateway or figure out a way to support multiple base URLs. Similarly, the prefixes /auth and /share are currently the result of using custom domain mappings with API Gateway. We would need to either recreate them as actual paths under the API gateways or make the CLI smarter to use these prefixes or not depending on whether a custom domain is being used or not.
  • Doing conditional resources in CloudFormation is notoriously painful...
@lmammino lmammino added enhancement New feature or request help wanted Extra attention is needed labels Oct 10, 2022
@eoinsha
Copy link
Collaborator

eoinsha commented Oct 16, 2022

This example of conditional domain resources in CloudFormation might help ease the pain: https://github.com/fourTheorem/slic-starter/blob/25ac05419f98af2ce7f0c5de9f89e0981a5b1aba/packages/checklist-service/serverless.yml#L128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants