Ensure ending newline in renderer, rather than renderer and diff

awsdocs · Nov 27, 2024 · 205080c · 205080c
1 parent ab6a7d9
commit 205080c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/.tools/readmes/render.py b/.tools/readmes/render.py
@@ -333,7 +333,11 @@ def write(self):
     def read_current(self):
         try:
             with self.readme_filename.open("r", encoding="utf-8") as f:
-                return f.read()
+                current = f.read()
+                if current[-1] != "\n":
+                    # Ensure there's always an ending newline
+                    current += "\n"
+                return current
         except FileNotFoundError:
             return ""
 

diff --git a/.tools/readmes/runner.py b/.tools/readmes/runner.py
@@ -173,12 +173,6 @@ def main():
 
 def make_diff(renderer, id):
     current = renderer.read_current().split("\n")
-    if current[-1] != "":
-        # Ensure final "last" line
-        current += [""]
     expected = renderer.readme_text.split("\n")
-    if expected[-1] != "":
-        # Ensure final "last" line
-        expected += [""]
     diff = unified_diff(current, expected, f"{id}/current", f"{id}/expected")
     return "\n".join(diff)