New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java V2 FSA #5362

Merged

meyertst-aws merged 68 commits into awsdocs:main from scmacdon:fsa2

Sep 27, 2023

Contributor

scmacdon commented Sep 6, 2023

This pull request is a new PR for Java V2 FSA

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

scmacdon added On Call Review complete Text Review complete Java-v2 labels

scmacdon requested a review from Laren-AWS

September 6, 2023 00:17

scmacdon self-assigned this

github-actions bot added the GitHub settings label

scmacdon requested review from ford-at-aws and removed request for Laren-AWS

September 6, 2023 14:50

ford-at-aws approved these changes

View reviewed changes

ford-at-aws previously requested changes

View reviewed changes

Contributor

ford-at-aws left a comment

See requested changes in previous PR, specifically about updating the README. Not seeing that in this new PR.

Laren-AWS requested changes

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/FSAApplicationResources.java Outdated Show resolved Hide resolved

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/PollyHanlder.java Outdated Show resolved Hide resolved

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/PollyHanlder.java Outdated Show resolved Hide resolved

javav2/usecases/creating_fsa_app/README.md Outdated Show resolved Hide resolved

javav2/usecases/creating_fsa_app/README.md Outdated Show resolved Hide resolved

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/ModifyLambda.java Outdated Show resolved Hide resolved

Laren-AWS requested changes

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/ModifyLambda.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

applications/feedback_sentiment_analyzer/cdk/lib/functions.ts Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

applications/feedback_sentiment_analyzer/cdk/lib/functions.ts Outdated Show resolved Hide resolved

Laren-AWS previously requested changes

View reviewed changes

javav2/usecases/creating_fsa_app/README.md Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/PollyHandler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/PollyHandler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/PollyHandler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/PollyHandler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/PollyHandler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/S3Handler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/S3Handler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/S3Handler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/SentimentHandler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/SentimentHandler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/TranslateHandler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/TranslateHandler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

javav2/usecases/creating_fsa_app/src/main/java/com/example/fsa/handlers/TranslateHandler.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

...usecases/creating_fsa_app/src/main/java/com/example/fsa/services/DetectSentimentService.java Outdated Show resolved Hide resolved

cpyle0819 reviewed

View reviewed changes

...usecases/creating_fsa_app/src/main/java/com/example/fsa/services/DetectSentimentService.java Outdated Show resolved Hide resolved

scmacdon added 29 commits

September 27, 2023 09:04


          added transfer manager API

1c9eeec


          modified java to use async clients

54ba8a7


          modified java to use async clients

67560be


          modified java to use async clients

93bd574


          modified java to use async clients

3adbb06


          modified java to use async clients

8ab73f0


          updated the Readme

00bdbb6


          updated the Readme

27e4462


          updated the Readme

26ffb77


          updated the Readme

0ad7ddd


          updated the Readme

ce023a6


          updated the Readme

d4ac9c5


          updated transfer manager logic

50942fa


          updated transfer manager logic

bf316a8


          updated transfer manager logic

a785b82


          add tests

680f3ba


          updated POM

0d0ae96


          modified TM API code based on SDK team suggestion

558545b


          modified tests to test the Service Classes code and make sure they al…

e0d40da

…l work


          modified pom

f8fa366


          updated the upload logic using transfer manager

6d74aab


          updated the POM in Readme

cb1b89b


          updated the POM in Readme

5c48b4f


          updated headings in Readme

1bbb175


          updated headings in Readme

7110e00


          rolled in comments

f59c87c


          rolled in comments

63ab0e8


          rolled in comments

0c0ffa4


          rolled in comments

7c221cb

meyertst-aws merged commit 2e09dd8 into awsdocs:main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Application Follow GitHub settings Java-v2 On Call Review complete Text Review complete