Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET v3: Linting and formatting action, initial run on dotnetv3 folder. #5580

Merged
merged 10 commits into from
Oct 27, 2023

Conversation

rlhagerm
Copy link
Contributor

@rlhagerm rlhagerm commented Oct 26, 2023

Adding a dotnet lint and format action. Updating existing files within the dotnetv3 folder to meet the formatting and linting standards. Updating related READMEs, solution files, and build commands. Merge check will no longer allow changes that violate the linting and formatting in the dotnetv3 folder or that break the build for the top level solution.
Formatting updated includes:

  • Standardizing headers
  • Organizing Usings
  • Ordering methods and namespaces
  • Whitespace fixes

Closes #5508

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added DotNet-v3 This issue relates to the AWS SDK for .NET V3 GitHub settings This affects GitHub settings labels Oct 26, 2023
@rlhagerm rlhagerm self-assigned this Oct 26, 2023
@rlhagerm rlhagerm added Text Review not needed This contains no text which needs review Task labels Oct 26, 2023
@rlhagerm rlhagerm requested review from a team and DavidSouther and removed request for a team October 26, 2023 19:57
* Adding dotnet lint and format action. Updating existing files within the dotnetv3 folder to meet the formatting and linting standards. Updating related READMEs, solution files, and build commands.
* Adding dotnet lint and format action. Updating existing files within the dotnetv3 folder to meet the formatting and linting standards. Updating related READMEs, solution files, and build commands.
@rlhagerm rlhagerm added the On Call Review needed This work needs an on-call review label Oct 26, 2023
@scmacdon scmacdon added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 27, 2023
@scmacdon scmacdon merged commit fe9aa98 into awsdocs:main Oct 27, 2023
@rlhagerm rlhagerm deleted the dotnet-lint-format branch November 9, 2023 20:50
ford-at-aws pushed a commit that referenced this pull request Dec 15, 2023
…r. (#5580)

* Dotnet format merge (#8)

* Adding dotnet lint and format action. Updating existing files within the dotnetv3 folder to meet the formatting and linting standards. Updating related READMEs, solution files, and build commands.

* Fixing modifiers.

* Turn off .NET superlinter.

* Dotnet format merge (#8)

* Adding dotnet lint and format action. Updating existing files within the dotnetv3 folder to meet the formatting and linting standards. Updating related READMEs, solution files, and build commands.

* Fixing modifiers.

* Turn off .NET superlinter.

* Removing unused using statements to pass the new formatting check.

* Remove test branch from the action.

* Add success or failure to formatter check.

* Update dotnetv3/Aurora/Scenarios/AuroraScenario.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DotNet-v3 This issue relates to the AWS SDK for .NET V3 GitHub settings This affects GitHub settings On Call Review complete On call review complete Text Review not needed This contains no text which needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET lint and format
3 participants