-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET v3: Linting and formatting action, initial run on dotnetv3 folder. #5580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e87e2de
to
8242f3a
Compare
* Adding dotnet lint and format action. Updating existing files within the dotnetv3 folder to meet the formatting and linting standards. Updating related READMEs, solution files, and build commands.
* Adding dotnet lint and format action. Updating existing files within the dotnetv3 folder to meet the formatting and linting standards. Updating related READMEs, solution files, and build commands.
ae83434
to
6e80e92
Compare
DavidSouther
approved these changes
Oct 26, 2023
scmacdon
reviewed
Oct 27, 2023
scmacdon
approved these changes
Oct 27, 2023
rlhagerm
commented
Oct 27, 2023
ford-at-aws
pushed a commit
that referenced
this pull request
Dec 15, 2023
…r. (#5580) * Dotnet format merge (#8) * Adding dotnet lint and format action. Updating existing files within the dotnetv3 folder to meet the formatting and linting standards. Updating related READMEs, solution files, and build commands. * Fixing modifiers. * Turn off .NET superlinter. * Dotnet format merge (#8) * Adding dotnet lint and format action. Updating existing files within the dotnetv3 folder to meet the formatting and linting standards. Updating related READMEs, solution files, and build commands. * Fixing modifiers. * Turn off .NET superlinter. * Removing unused using statements to pass the new formatting check. * Remove test branch from the action. * Add success or failure to formatter check. * Update dotnetv3/Aurora/Scenarios/AuroraScenario.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DotNet-v3
This issue relates to the AWS SDK for .NET V3
GitHub settings
This affects GitHub settings
On Call Review complete
On call review complete
Text Review not needed
This contains no text which needs review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a dotnet lint and format action. Updating existing files within the dotnetv3 folder to meet the formatting and linting standards. Updating related READMEs, solution files, and build commands. Merge check will no longer allow changes that violate the linting and formatting in the dotnetv3 folder or that break the build for the top level solution.
Formatting updated includes:
Closes #5508
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.