Add example React client application for Cognito user pools #6212
Conversation
github-actions
bot
added
Javascript-v3
|
|
||
| class RunnerTests: XCTestCase { | ||
|
|
||
| func testExample() { |
There was a problem hiding this comment.
Should we be concerned that there are no tests here?
There was a problem hiding this comment.
This PR adds a directory to the swift/example_code/cognito-identity directory named IOS_AWS_SDK. This is not a descriptive name, and is in all-caps unlike other directories in the Swift part of the repository. Please change the name of this directory.
Hm. This appears to be an example using the old iOS SDK, not the Swift SDK. I don't think it belongs where it's been put in the repository -- the /swift tree is for SDK for Swift examples. I can't get this example to build on my MacBook Pro with M2 Pro chip. I get a bunch of "No library for this platform" errors when trying to deal with the iOS SDK parts of the build.
Until these things are cleared up, I can't do much to review this.
|
Renamed directory. @bhatti is original author and wanted to know what library should be used and if you have any reference examples. |
github-actions
bot
removed
Kotlin
AMZ-brandon
changed the title
brmur
requested review from
shepazon
and removed request for
scmacdon and
shepazon
|
@AMZ-brandon the linter and metadata validator is failing. Can you take a look and let me know if you need any help? |
|
Now that this is just for JavaScript, I'm not the right person to review this. |
Working with @cpyle0819 on it. Thanks for the input so far! |
cpyle0819
added
Workflow
github-actions
bot
added
C++
github-actions
bot
removed
Python
I am adding some application code contributed by the Cognito service team to be referenced in a future documentation update.
Each does basic sign-up, confirmation, sign-in operations.
javascriptv3/example_code/cognito-identity-provider/scenarios/react-web-app: A web application for ReactJS
kotlin/services/cognito/src/main/Flutter_AWS_SDK: A mobile Android app in Flutterswift/example_code/cognito-identity/IOS_AWS_SDK/MyIOSApp: A mobile iOS app in SwiftBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.