Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Cognito react app #6261

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

AMZ-brandon
Copy link
Contributor

This pull request adds a ReactJS web application for a basic Cognito user pools implementation.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the Javascript-v3 This issue relates to the AWS SDK for Javascript V3 label Mar 19, 2024
@cpyle0819 cpyle0819 added Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs. Follow After Scouts, more languages are added to examples as Follows. labels Mar 19, 2024
@cpyle0819 cpyle0819 self-assigned this Mar 19, 2024
@cpyle0819 cpyle0819 added On Call Review needed This work needs an on-call review and removed On Call Review needed This work needs an on-call review labels Mar 19, 2024
@cpyle0819
Copy link
Contributor

cpyle0819 commented Mar 21, 2024

@AMZ-brandon just realized that you're not doing anything with the credentials after they are fetched. This is a part of the workflow that is missing in a large lot of examples, and it's debatable how much value this example will have without it.

Something as simple as listing S3 buckets would be enough.

@cpyle0819 cpyle0819 added the On Call Review needed This work needs an on-call review label Mar 22, 2024
@rlhagerm rlhagerm added On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc. and removed Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs. Follow After Scouts, more languages are added to examples as Follows. On Call Review needed This work needs an on-call review labels Mar 22, 2024
@rlhagerm rlhagerm force-pushed the cognito-react-app branch from d8ce94e to 6a6503b Compare March 22, 2024 17:30
@rlhagerm rlhagerm merged commit 9f952fb into awsdocs:main Mar 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants