Simplify presigning example #7065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the "download a file" example to use a custom configuration for the presigned GetObject request.
shepazon
added
Swift
|
I'm going to move the example to a different function than GetObject. |
|
So wait until it is moved before I review it?
From: Eric Shepherd ***@***.***>
Reply-To: awsdocs/aws-doc-sdk-examples ***@***.***>
Date: Thursday, November 14, 2024 at 11:10 AM
To: awsdocs/aws-doc-sdk-examples ***@***.***>
Cc: "Meyer, Steve" ***@***.***>, Review requested ***@***.***>
Subject: Re: [awsdocs/aws-doc-sdk-examples] Add advanced presigning example (PR #7065)
I'm going to move the example to a different function than GetObject.
—
Reply to this email directly, view it on GitHub<#7065 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZ6XNGCM6EI3MK7OV5QDCDD2ATDNZAVCNFSM6AAAAABRZCYFV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWHAYTSNJWGY>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
Yeah.
|
…to using PutObject. This lets GetObject be used in doc content as the example for a basic presign operation, while PutObject can be used for more involved presigning ops.
|
Ready for review, @meyertst-aws. |
|
I added a call to HeadObject in the upload function to provide an example of using a custom configuration for a presigned URL in which the customized config is actually different from one the S3Client is configured to use. |
|
This is now ready to review. |
meyertst-aws
approved these changes
Nov 22, 2024
swift/example_code/s3/presigned-urls/Sources/presigned-upload/entry.swift
Outdated
Show resolved
Hide resolved
|
Feedback addressed. Ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the "upload a file" example to include a custom configuration for one of its
PutObjectrequests. It also removes the multi-part portion of the example, which will come back shortly as a separate example, and splits the remaining upload and download examples into two separate programs, one which uploads files with or without presigning, aand one which downloads files with or without presigning.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.