Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Add log group argument to CloudWatchQuery. Addresses #7022 #7066

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

sslogar
Copy link
Contributor

@sslogar sslogar commented Nov 14, 2024

The CloudWatchQuery class now accepts log_group and query_string as arguments.

@github-actions github-actions bot added the Python This issue relates to the AWS SDK for Python (boto3) label Nov 14, 2024
@sslogar
Copy link
Contributor Author

sslogar commented Nov 18, 2024

@rlhagerm Please see my PR for this issue: #7022

@sslogar sslogar changed the title Python: Add log group argument to CloudWatchQuery Python: Add log group argument to CloudWatchQuery. Address #7022 Nov 18, 2024
@sslogar sslogar changed the title Python: Add log group argument to CloudWatchQuery. Address #7022 Python: Add log group argument to CloudWatchQuery. Addresses #7022 Nov 18, 2024
@rlhagerm rlhagerm assigned rlhagerm and unassigned ford-at-aws Dec 9, 2024
@rlhagerm rlhagerm self-requested a review December 9, 2024 15:40
@rlhagerm rlhagerm force-pushed the add-cloudwatch-args branch from 6ca2325 to f2d5564 Compare December 9, 2024 15:40
Copy link
Contributor

@rlhagerm rlhagerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified functionality and updated related README.

@rlhagerm rlhagerm force-pushed the add-cloudwatch-args branch from 6c5f708 to 85b3ec5 Compare December 10, 2024 20:24
@rlhagerm rlhagerm added On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc. On Call Review needed This work needs an on-call review and removed On Call Review complete On call review complete On Call Review needed This work needs an on-call review labels Dec 10, 2024
@rlhagerm rlhagerm force-pushed the add-cloudwatch-args branch from 85b3ec5 to d677f37 Compare December 11, 2024 13:21
@rlhagerm rlhagerm merged commit bdfa9e5 into awsdocs:main Dec 11, 2024
15 checks passed
meyertst-aws pushed a commit to meyertst-aws/aws-doc-sdk-examples that referenced this pull request Dec 19, 2024
meyertst-aws pushed a commit to meyertst-aws/aws-doc-sdk-examples that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Call Review complete On call review complete Python This issue relates to the AWS SDK for Python (boto3) Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants