Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW Socket Shutdown Process Update #705

Merged
merged 54 commits into from
Feb 10, 2025
Merged

NW Socket Shutdown Process Update #705

merged 54 commits into from
Feb 10, 2025

Conversation

xiazhvera
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 57.29730% with 79 lines in your changes missing coverage. Please review.

Project coverage is 78.86%. Comparing base (96e8643) to head (369eb0b).

Files with missing lines Patch % Lines
source/channel_bootstrap.c 52.30% 62 Missing ⚠️
source/socket_channel_handler.c 51.51% 16 Missing ⚠️
source/posix/socket.c 94.44% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           nw_socket     #705      +/-   ##
=============================================
- Coverage      79.58%   78.86%   -0.72%     
=============================================
  Files             30       30              
  Lines           6124     6280     +156     
=============================================
+ Hits            4874     4953      +79     
- Misses          1250     1327      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from grand_dispatch_queue_edit to grand_dispatch_queue February 5, 2025 22:54
@xiazhvera xiazhvera changed the base branch from grand_dispatch_queue to nw_socket February 6, 2025 19:45
@xiazhvera xiazhvera merged commit 8c4bdba into nw_socket Feb 10, 2025
46 of 49 checks passed
@xiazhvera xiazhvera deleted the nw_socket_shutdown branch February 10, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants