Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or replace hardcoded Route53 tests #1370

Open
ianbotsf opened this issue Jul 25, 2024 · 0 comments
Open

Update or replace hardcoded Route53 tests #1370

ianbotsf opened this issue Jul 25, 2024 · 0 comments
Labels
bug This issue is a bug. p3 This is a minor priority issue

Comments

@ianbotsf
Copy link
Contributor

Describe the bug

We encountered a preview build failure recently from an updated Route53 model which changed the model version from 2013-04-01 to 2015-01-01. This caused the unit tests generated from the hardcoded test model to fail because they expect 2013-04-01 in the URI. We should either:

  • Update these unit tests to be more flexible wrt model changes –or–
  • Replace these generated unit tests with hand-written unit tests of the customized zone trimming behavior

Expected behavior

Unit tests shouldn't fail on valid model updates

Current behavior

Uni tests fail on valid model updates

Steps to Reproduce

See above

Possible Solution

No response

Context

No response

AWS SDK for Kotlin version

1.2.55

Platform (JVM/JS/Native)

JVM

Operating system and version

(n/a)

@ianbotsf ianbotsf added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 25, 2024
@ianbotsf ianbotsf removed the needs-triage This issue or PR still needs to be triaged. label Aug 5, 2024
@RanVaknin RanVaknin added the p3 This is a minor priority issue label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

2 participants