Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retryStrategy configuration option for waiters #1183

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

lauzadis
Copy link
Contributor

@lauzadis lauzadis commented Nov 20, 2024

Add optional configuration for waiters' RetryStrategy

Issue #

Closes awslabs/aws-sdk-kotlin#1431 and closes #839

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis requested a review from a team as a code owner November 20, 2024 17:57
Copy link

Affected Artifacts

No artifacts changed size

@lauzadis lauzadis changed the base branch from main to v1.4 November 20, 2024 21:48
Comment on lines 1 to 8
{
"id": "1c6d0436-16c3-46d6-9fb5-d9af6c119ba5",
"type": "feature",
"description": "Add `retryStrategy` configuration option for waiters",
"issues": [
"https://github.com/awslabs/aws-sdk-kotlin/issues/1431"
]
}
Copy link
Contributor

@ianbotsf ianbotsf Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Is breaking, requires minor version bump

@lauzadis lauzadis merged commit 869fb84 into v1.4 Nov 26, 2024
10 checks passed
@lauzadis lauzadis deleted the feat-configure-waiters branch November 26, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Waiters do not have a configurable retry / timeout strategy Allow customizing retry options for waiters
3 participants