Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument DynamoDB spans with semantic attributes #986

Open
1 task done
aajtodd opened this issue Jul 18, 2023 · 0 comments
Open
1 task done

Instrument DynamoDB spans with semantic attributes #986

aajtodd opened this issue Jul 18, 2023 · 0 comments
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue queued This issues is on the AWS team's backlog

Comments

@aajtodd
Copy link
Collaborator

aajtodd commented Jul 18, 2023

Describe the feature

OpenTelemetry/X-Ray define several additional span attributes for one or more DDB operations:

https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/instrumentation/aws-sdk/#dynamodb

https://github.com/aws/aws-xray-sdk-java/blob/v2.14.0/aws-xray-recorder-sdk-aws-sdk-v2/src/main/resources/com/amazonaws/xray/interceptors/DefaultOperationParameterWhitelist.json

Is your Feature Request related to a problem?

It would be great if these attributes were instrumented by default in the SDK and didn't need to be set externally via an interceptor in specific instrumentation libraries (e.g. OTeL, X-Ray, etc).

Proposed Solution

Add one or more interceptors automatically registered to extend the set of attributes to include the DDB attributes documented.

Describe alternative solutions or features you've considered

No response

Acknowledge

  • I may be able to implement this feature request

AWS Kotlin SDK version used

N/A

Platform (JVM/JS/Native)

N/A

Operating System and version

N/A

@aajtodd aajtodd added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 18, 2023
@lauzadis lauzadis removed the needs-triage This issue or PR still needs to be triaged. label Jun 4, 2024
@RanVaknin RanVaknin added p2 This is a standard priority issue queued This issues is on the AWS team's backlog labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

No branches or pull requests

3 participants