diff --git a/MWAA/tests/test_verify_env.py b/MWAA/tests/test_verify_env.py index 97d9579..979d957 100644 --- a/MWAA/tests/test_verify_env.py +++ b/MWAA/tests/test_verify_env.py @@ -97,7 +97,7 @@ def test_validate_envname(): def test_validate_profile(): ''' - test invalid and valid names for MWAA environment + test invalid and valid names for the profile ''' with pytest.raises(argparse.ArgumentTypeError) as excinfo: profile_name = 'test space' @@ -115,6 +115,12 @@ def test_validate_profile(): profile_name = 'HelloWorld' result = verify_env.validation_profile(profile_name) assert result == profile_name + profile_name = '_HelloWorld' + result = verify_env.validation_profile(profile_name) + assert result == profile_name + profile_name = 'Hello-World' + result = verify_env.validation_profile(profile_name) + assert result == profile_name def test_check_ingress_acls(): diff --git a/MWAA/verify_env/verify_env.py b/MWAA/verify_env/verify_env.py index 1d620af..08091c1 100644 --- a/MWAA/verify_env/verify_env.py +++ b/MWAA/verify_env/verify_env.py @@ -88,7 +88,7 @@ def validation_profile(profile_name): ''' verify profile name doesn't have path to files or unexpected input ''' - if re.match(r"^[a-zA-Z0-9]*$", profile_name): + if re.match(r"^[a-zA-Z0-9-_]*$", profile_name): return profile_name raise argparse.ArgumentTypeError("%s is an invalid profile name value" % profile_name)