Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: customise the name of the scan-status tag #810

Open
direvus opened this issue Apr 27, 2023 · 2 comments
Open

Feature request: customise the name of the scan-status tag #810

direvus opened this issue Apr 27, 2023 · 2 comments

Comments

@direvus
Copy link

direvus commented Apr 27, 2023

Some organisations have policies in place around allowed tag names, tag naming conventions, namespacing and such.

It would be handy to have the option to set the name of the "scan-status" tag, as a prop when deploying ServerlessClamscan.

@dontirun
Copy link
Contributor

It's possible, but I don't think being able to completely change the tag name is a good idea. It can reduce clarity in both the deployed solution and make the props confusing as well. I'd like to know more about the policies before discussing a potential solution. Is the policy around prefixing tag names?

@direvus
Copy link
Author

direvus commented Apr 28, 2023

A prefix is one possible policy. You might also have users with specific naming conventions they want to apply, like maybe they want ScanStatus or SCAN_STATUS.

You could also have situations where there are multiple scanning tools in play, and we want to make it clear which tool is responsible for the tag, so something like clamav-scan-status or scan-status-clamav might be desired.

I don't really understand the concern about reducing clarity, but in any case, if you're not interested in adding the feature then go ahead and close it. I'll just arrange to change the tags when I move the object to the next bucket in the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants