Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnapshotUploader::upload_from_file should not retry file permission errors #221

Open
iliana opened this issue Dec 27, 2022 · 0 comments
Open

Comments

@iliana
Copy link

iliana commented Dec 27, 2022

I am currently working on an image builder (go figure!), which happens to write images with root:root -rw------- permissions. Running coldsnap as my regular user doesn't work because it can't read it, but it doesn't tell me that1; it just hangs at 0% progress.

This is related to #216 and similar, but there are certain classes of errors that should just not be retried.

Unfortunately coming up with a list of errors that should never be retried is pretty obnoxious so I might suggest attempting to open the file for reading before even calling ebs:StartSnapshot; while ENOENT will occur at the fs::metadata call, that call doesn't catch this type of permissions issue.

Footnotes

  1. actually it does if i'm patient and willing to wait ~2.5 minutes apparently longer but i'm not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant