-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about Mountpoint Client Performance #236
Comments
Hello @ryxli, thank you for opening up that issue. I can't seem to reproduce the performance downgrade you're observing: would you mind sharing more details? Namely, your instance type and Python + boto3 + s3torchconnector versions? Here's what I tried:
import time
import boto3
from s3torchconnector._s3client import S3Client
def issue236():
bucket = "my_bucket"
key = "large_2gb"
# s3 torch connector snippet
s3_client = S3Client("ap-south-1")
tic = time.perf_counter()
s3_client.get_object(bucket, key).read()
toc = time.perf_counter()
print(f"mountpoint finishes in {toc - tic:0.4f} seconds")
# boto3 snippet
client = boto3.client('s3')
tic = time.perf_counter()
client.download_file(bucket, key, 'my_large_2gb')
toc = time.perf_counter()
print(f"boto3 finishes in {toc - tic:0.4f} seconds")
if __name__ == "__main__":
issue236() Overall, the PyTorch connector runs consistently faster than boto3 (example run):
Finally, here are the versions used for this test:
|
Am still able to reproduce this issue with your code snippet, this time with a 6GB object. S3 Bucket region: us-east-1
Output:
Versions:
boto3 is installed with |
Hi @ryxli, I ran the snippet again too, against a bucket in a different region (same setup as you: EC2 instance in One question though: I noticed in your PyTorch version an unusual number ( |
I am running this snippet from within a container on the ec2 instance, also from a Jupyter notebook |
Hi @ryxli, As discussed offline with you, we'll proceed to close this issue for now, as we were unable to reproduce the problem. |
s3torchconnector version
latest
s3torchconnectorclient version
latest
AWS Region
us-east-1, ap-south-1
Describe the running environment
EC2 instance
What happened?
Getting some significant performance difference between regular boto3 download_obj which uses s3 crt transfer config and mountpoint client, even with various settings for throughput and part size. boto3 client just use the default settings
To reproduce try downloading a 2GB file from s3 with mountpoint client (S3Reader) vs regular boto3 client.
Results:
However, this performance gap seems to disappear in multiprocess setting, but again without any tuning on the transferconfig for boto3
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: