Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Artifact fetcher does not honor mirrors #1013

Open
turan18 opened this issue Dec 27, 2023 · 0 comments
Open

[Bug] Artifact fetcher does not honor mirrors #1013

turan18 opened this issue Dec 27, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@turan18
Copy link
Contributor

turan18 commented Dec 27, 2023

Description

The snapshotter fetches SOCI artifacts for every unique image manifest digest. We take the source information of a blob/layer, most importantly the original image reference, on the first Prepare call and create a new ORAS *remote.Repository that we use to fetch artifacts. This means that even if we had a mirror configured for a host, we would still be fetching SOCI artifacts from the original host. We should support fetching from multiple endpoints, just like we do in our span fetcher.

Steps to reproduce the bug

No response

Describe the results you expected

We could expand sociContext to include the host configurations, so that during Init we can loop through each host to try and fetch artifacts.

Host information

  1. OS:
  2. Snapshotter Version:
  3. Containerd Version:

Any additional context or information about the bug

No response

@turan18 turan18 added the bug Something isn't working label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant