From 3b46feaeaf8048d46f85d023295e65563b84d7d6 Mon Sep 17 00:00:00 2001 From: Aumetra Weisman Date: Sun, 8 Sep 2024 17:00:50 +0200 Subject: [PATCH] Fix 128bit integer serialization --- Cargo.lock | 1 + olpc-cjson/Cargo.toml | 3 +++ olpc-cjson/src/lib.rs | 30 ++++++++++++++++++++++++++++++ 3 files changed, 34 insertions(+) diff --git a/Cargo.lock b/Cargo.lock index 74c92186..0cfc4991 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1626,6 +1626,7 @@ name = "olpc-cjson" version = "0.1.3" dependencies = [ "serde", + "serde_derive", "serde_json", "unicode-normalization", ] diff --git a/olpc-cjson/Cargo.toml b/olpc-cjson/Cargo.toml index f3522dcf..228e7bdb 100644 --- a/olpc-cjson/Cargo.toml +++ b/olpc-cjson/Cargo.toml @@ -12,3 +12,6 @@ edition = "2018" serde = "1" serde_json = "1" unicode-normalization = "0.1" + +[dev-dependencies] +serde_derive = "1" diff --git a/olpc-cjson/src/lib.rs b/olpc-cjson/src/lib.rs index 9bee79aa..e8c534f3 100644 --- a/olpc-cjson/src/lib.rs +++ b/olpc-cjson/src/lib.rs @@ -146,10 +146,12 @@ impl Formatter for CanonicalFormatter { wrapper!(write_i16, i16); wrapper!(write_i32, i32); wrapper!(write_i64, i64); + wrapper!(write_i128, i128); wrapper!(write_u8, u8); wrapper!(write_u16, u16); wrapper!(write_u32, u32); wrapper!(write_u64, u64); + wrapper!(write_u128, u128); fn write_f32(&mut self, _writer: &mut W, _value: f32) -> Result<()> { float_err!() @@ -468,4 +470,32 @@ mod tests { ]; assert_eq!(expected, encoded); } + + #[test] + fn encode_u128_i128() { + #[derive(serde_derive::Serialize)] + struct Object { + u128: u128, + i128: i128, + } + + let value = Object { + u128: u128::MAX, + i128: i128::MIN, + }; + + let mut buf = Vec::new(); + let mut ser = Serializer::with_formatter(&mut buf, CanonicalFormatter::new()); + value.serialize(&mut ser).unwrap(); + + let expected = [ + 123, 34, 105, 49, 50, 56, 34, 58, 45, 49, 55, 48, 49, 52, 49, 49, 56, 51, 52, 54, 48, + 52, 54, 57, 50, 51, 49, 55, 51, 49, 54, 56, 55, 51, 48, 51, 55, 49, 53, 56, 56, 52, 49, + 48, 53, 55, 50, 56, 44, 34, 117, 49, 50, 56, 34, 58, 51, 52, 48, 50, 56, 50, 51, 54, + 54, 57, 50, 48, 57, 51, 56, 52, 54, 51, 52, 54, 51, 51, 55, 52, 54, 48, 55, 52, 51, 49, + 55, 54, 56, 50, 49, 49, 52, 53, 53, 125, + ]; + + assert_eq!(buf, expected); + } }