From f52ce5069a1bc16034e8e89d38dc6c3b6ae2bcee Mon Sep 17 00:00:00 2001 From: Baptiste Girard-Carrabin Date: Fri, 8 Nov 2024 15:27:22 +0100 Subject: [PATCH] [controller] Properly retry failures The `retryModificationFailures` parameter was never used when initializing the modify controller. As a result, modification failures were not retried until the PVC was re-processed (because the driver restarted or the PVC re-added to the cache) --- pkg/controller/controller.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/controller/controller.go b/pkg/controller/controller.go index bd4ca15..d47f6b1 100644 --- a/pkg/controller/controller.go +++ b/pkg/controller/controller.go @@ -57,6 +57,7 @@ func NewModifyController( claims: pvcInformer.Informer().GetStore(), eventRecorder: eventRecorder, modificationInProgress: make(map[string]struct{}), + retryFailures: retryModificationFailures, } pvcInformer.Informer().AddEventHandlerWithResyncPeriod(cache.ResourceEventHandlerFuncs{