Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISMN fixtures / settings #845

Open
wpreimes opened this issue Mar 19, 2024 · 2 comments
Open

ISMN fixtures / settings #845

wpreimes opened this issue Mar 19, 2024 · 2 comments

Comments

@wpreimes
Copy link
Collaborator

There is a "number of stations" field in the networks fixture, but this depends on the version of the ismn data. What is it used for?

@wpreimes
Copy link
Collaborator Author

wpreimes commented May 16, 2024

Apparently nothing, we can remove it I guess, Same applies to the "country", which doesnt make much sense to have in the fixtures.

@wpreimes wpreimes changed the title ISMNf ixtures ISMN fixtures / settings May 16, 2024
@wpreimes
Copy link
Collaborator Author

wpreimes commented May 16, 2024

  • Remove the number_of_stations and country fields from the networks fixture.
  • Make variables depend on versions, not datasets. Variable names can change between versions.
  • When multiple variables are available sort them by their depth (consider adding varible depth info), default should be the surface variable
  • ALL ISMN stations in all networks should be activated by default, we have the FRM filter now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant