feat: add stellar upgrader contract to the deploy-contract.js script #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milapsheth
approved these changes
Dec 24, 2024
| const newWasmHash = await uploadWasm(wasmPath, wallet, chain); | ||
| printInfo('New Wasm hash', serializeValue(newWasmHash)); | ||
|
|
||
| const operation = Operation.invokeContractFunction({ | ||
| contract: contractAddress, | ||
| contract: chain.contracts.upgrader.address, |
There was a problem hiding this comment.
Include this in the validation above as well in case it's not been deployed/present in the config
| nativeToScVal(options.newVersion), | ||
| nativeToScVal(newWasmHash), | ||
| nativeToScVal([options.migrationData]), | ||
| ], |
There was a problem hiding this comment.
Suggested change
| ], | |
| ].map(nativeToScVal), |
Can use a map instead
| await broadcast(operation, wallet, chain, 'Upgraded contract', options); | ||
| chain.contracts[contractName].wasmHash = serializeValue(newWasmHash); | ||
| printInfo('Contract upgraded successfully!', contractAddress); | ||
| } | ||
|
|
||
| async function createUpgradeAuths(contractAddress, newWasmHash, migrationData, chain, wallet) { | ||
| // 20 seems a reasonable number of ledgers to allow for the upgrade to take effect |
There was a problem hiding this comment.
Create a global constant for it. Could also create an option with a default of 20 though I don't see us configuring it
| ); | ||
| } | ||
|
|
||
| const createAuthorizedFunc = (contractAddress, functionName, args) => |
There was a problem hiding this comment.
Move this to the stellar utils.js
milapsheth
reviewed
Dec 24, 2024
| @@ -200,6 +245,8 @@ function main() { | |||
| .description('Upgrade a Stellar contract') | |||
| .argument('<contract-name>', 'contract name to deploy') | |||
| .addOption(new Option('--wasm-path <wasmPath>', 'path to the WASM file')) | |||
| .addOption(new Option('--new-version <newVersion>', 'new version of the contract')) | |||
| .addOption(new Option('--migration-data <migrationData>', 'migration data')) | |||
There was a problem hiding this comment.
Add an upgrade usage example in the stellar/README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-6746