Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable browser CLI arguments when opening links #105

Open
2 tasks done
DespairScent opened this issue Nov 24, 2023 · 1 comment
Open
2 tasks done

Add configurable browser CLI arguments when opening links #105

DespairScent opened this issue Nov 24, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@DespairScent
Copy link

Is your feature request related to a problem?

I'm using many browser profiles, and there is only one with Minecraft (Miscrosoft) account. When I log in via AuthMe, it directs me to the last opened (last used?) profile browser window, which is not always the right one. Most time, I first need to open the browser profile with the game account and only then click the AuthMe button. It's not very convenient.

Describe the solution you'd like.

Add config entry to specify command that runs browser. For example, google-chrome --profile-directory=ProfileWithMinecraftAccount

Describe alternatives you've considered.

.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported mod version.

Other

.

@axieum
Copy link
Owner

axieum commented Nov 29, 2023

Hi, this is a neat idea to include, I can see how this could impact people using multiple profiles. Thanks for raising!

Just noting the affected lines of code where we would need to pass the optional parameters to -

return acquireMSAuthCode(url -> Util.getOperatingSystem().open(url), browserMessage, executor);

Something to consider would be compatibility with non-chromium based browsers. But as you suggested, we can leave the browser flags blank by default, and the user can configure it as --profile-directory=OtherProfile to their browser's needs.

@axieum axieum added the enhancement New feature or request label Nov 29, 2023
@axieum axieum changed the title Custom browser command Add configurable browser CLI arguments when opening links Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants