Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement diophantine solvers from Mangara/diophantine #1056

Open
axkr opened this issue Aug 24, 2024 · 1 comment
Open

Implement diophantine solvers from Mangara/diophantine #1056

axkr opened this issue Aug 24, 2024 · 1 comment

Comments

@axkr
Copy link
Owner

axkr commented Aug 24, 2024

Use the diophantine solvers from this library:

in the FindInstance function

Enable: ToggleFeature.SOLVE_DIOPHANTINE = true to test the experimental implementation.

@Mangara: maybe you can help verifying the implementation?

@axkr axkr changed the title Implement some diophantine solvers from Mangara/diophantine Implement diophantine solvers from Mangara/diophantine Aug 24, 2024
axkr added a commit that referenced this issue Aug 24, 2024
- set ToggleFeature.SOLVE_DIOPHANTINE = true to test the experimental
implementation
@Mangara
Copy link

Mangara commented Oct 17, 2024

Looks reasonable to me. I'm glad you find it useful!

One small thing I noticed - I'm not sure why you try to detect the special cases yourself in diophantinePolynomial. QuadraticSolver.solve already defers to ParabolicSolver where appropriate.

axkr added a commit that referenced this issue Oct 17, 2024
- suggested by @Mangara
- `QuadraticSolver.solve` already defers to `ParabolicSolver`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants