Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish-prereleases = true only takes effect if publish jobs contains npm or homebrew #1744

Open
jackkleeman opened this issue Feb 4, 2025 · 0 comments · May be fixed by #1745
Open

publish-prereleases = true only takes effect if publish jobs contains npm or homebrew #1744

jackkleeman opened this issue Feb 4, 2025 · 0 comments · May be fixed by #1745

Comments

@jackkleeman
Copy link

Currently the logic to determine if publish-prereleases = true makes it into the plan depends on the prerelease=true flag being set for both of the npm and homebrew v1 config blocks. If both of those are None, we default to false. However, its possible to have custom publish jobs which would also be skipped on prerelease. I feel that if both are None, we should still respect the value set in the dist config, if its set, before defaulting to false. I think this could be a breaking change, if there are custom publish jobs that users are expecting not to execute on prerelease.

jackkleeman added a commit to jackkleeman/cargo-dist that referenced this issue Feb 4, 2025
jackkleeman added a commit to jackkleeman/cargo-dist that referenced this issue Feb 4, 2025
jackkleeman added a commit to jackkleeman/cargo-dist that referenced this issue Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant