Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle github-releases pagination #576

Open
Gankra opened this issue Aug 8, 2023 · 0 comments
Open

handle github-releases pagination #576

Gankra opened this issue Aug 8, 2023 · 0 comments
Labels

Comments

@Gankra
Copy link
Contributor

Gankra commented Aug 8, 2023

When oranda gets a list of a repo's Github Releases, it uses this REST api via our octolotl library/proxy. That API is paginated, defaulting to 30 items (max 100).

The result is that once a repo has more than 30 Github Releases, old ones start disappearing from Oranda's output.

Immediate implications:

  • Users with more than 30 releases will start to lose old ones in the output (notably this includes prereleases, so cutting a prerelease can make old stable releases disappear).

  • The DEBUG_DATA_CLAMP_DATE setting introduced in Gallery demo #575 doesn't effectively do its job, as filtering by date will prevent new entries but can't prevent old ones from being pushed out by the new ones. This means any repo in the gallery cutting a Release will break our snapshot tests (both oranda and cargo-dist have crossed this threshold).

Fixing this Properly would probably require changing octolotl to internally query all pages and then stitch the results together.

@Gankra Gankra added the bug label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant