Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad links while using oranda on a different branch #663

Open
vanilla-extracts opened this issue Nov 20, 2023 · 3 comments
Open

Bad links while using oranda on a different branch #663

vanilla-extracts opened this issue Nov 20, 2023 · 3 comments

Comments

@vanilla-extracts
Copy link

vanilla-extracts commented Nov 20, 2023

Link: https://github.com/coco33920/calc/blob/github-page/.github/workflows/web.yml
Job link: https://github.com/coco33920/calc/actions/runs/6934726471/job/18863434419

Config

{
  "styles": {
    "theme": "axodark",
    "favicon": "https://www.axo.dev/favicon.ico"
  },
  "components": {
    "changelog": true,
    "artifacts": {
      "package_managers": {
        "preferred": {
          "cargo": "cargo install mini-calc"
        }
      }
    },
    "mdbook": {
      "path": "./mini-calc"
    }
  },
    "build": {
    "static_dir": "docs/assets"
      }
}

I have "bad links" everywhere. I followed the docs pretty clearly so i don't understand what is not working.
oranda dev is working well.

@vanilla-extracts
Copy link
Author

I worked around,

  • disabling the hyperref verification
  • setting up a custom domain
    And it does the trick.

@ashleygwilliams
Copy link
Member

hey @coco33920 ! sorry you ran into this issue and thank you for explaining your work around. my suspicion is that this issue comes down to our dreaded "path-prefix" config, which exists because github hosts pages on .github.io/ - where here is the "path-prefix". it's definitely a bad experience and the link checking here seems to have added insult to injury. we are already working on ways to improve this and will take your report into account while we do so! if you have any thoughts feel free to include them here on this thread!

@vanilla-extracts
Copy link
Author

hey! Thanks for the quick answer!
Yeah I thought it would be the path prefix problem as in stated in #645
After a test and some digging with the firefox network tool, on a whim I tested with saying no to the "link tester" and well it kind of worked and with a custom domain name it worked totally. The request to the root are clearly visible in network tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants