Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest commons-lang3 to have no clashes with dep hierarchy #481

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Use latest commons-lang3 to have no clashes with dep hierarchy #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e92b06e
Upgrade to maven 3.9.5
alexsuter Nov 1, 2023
14cc4a1
Use latest commons-lang3 to have no clashes with dep hierarchy
alexsuter Nov 1, 2023
48fbc0e
Fix formatting
alexsuter Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM maven:3.8.6-eclipse-temurin-17
FROM maven:3.9.5-eclipse-temurin-17

# add an user with 1000 for the build in jenkins
RUN addgroup --gid 1000 build && adduser --uid 1000 --gid 1000 --disabled-password --gecos "" build
10 changes: 10 additions & 0 deletions connectivity/connectivity-demos-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,16 @@
<version>4.2.0</version>
<scope>test</scope>
</dependency>

<!-- fix this version. because axon ivy engine is using commons.text 1.11.0 which
requires commons.lang3 3.13.0. but this maven dependency hierarchy includes an older
version -->
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>3.13.0</version>
<scope>test</scope>
</dependency>
Comment on lines +100 to +105
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be better to define 'exclusions' on the dependency that has this transient dependency.
it seems like there are already other 'clashing' dependencies outline on them.

</dependencies>

<build>
Expand Down
3 changes: 0 additions & 3 deletions docker-entrypoint.sh
View file
Open in desktop

This file was deleted.

10 changes: 10 additions & 0 deletions workflow/workflow-demos-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,16 @@
<version>${web.tester.version}</version>
<scope>test</scope>
</dependency>

<!-- fix this version. because axon ivy engine is using commons.text 1.11.0 which
requires commons.lang3 3.13.0. but this maven dependency hierarchy includes an older
version -->
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>3.13.0</version>
<scope>test</scope>
</dependency>
</dependencies>

<build>
Expand Down
Loading