Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero value for QBCOMP variable #2

Open
aymhenry opened this issue Jul 14, 2020 · 2 comments
Open

Zero value for QBCOMP variable #2

aymhenry opened this issue Jul 14, 2020 · 2 comments

Comments

@aymhenry
Copy link
Owner

First

In class QCtrl_Ql8, method calculte_cycle
used to make cycle calculation, for configuration 2, mode 8

Variable (self.obj_data.QBCOMP) always zero.

I need to put

self.obj_data.QBCOMP = 0

somewhere before line 635, or an error will be raised.

Second
In file Ql5, the same problem

224		Cab.QBCOMP = 0.0
225		Cab.QFRZ = QTNOBOT  +  Cab.QBOTTM  +  Cab.QBCOMP

it is useless statement, better to remove (self.obj_data.QBCOMP ) from both equation.
confirmation required.

@oabdelaziz
Copy link
Contributor

Ayman, I prefer to keep them for conformity. QBCOMP is the heat flux from the compressor bottom compartment. I don't know what is QL5 and QL8 if these are configurations where the compressor compartment doesn't interact with the freezer - then you can safely remove it.

@aymhenry
Copy link
Owner Author

Good, I will keep this and others if any.

files Qlxxx like Ql13, Ql2, Ql467, Ql5 and Ql8.
Ql3 related to mode 3
Ql8 related to mode 8 etc.

Configuration 1 i.e mode 3 uses Ql13.py
Configuration 2 i.e mode 8 uses Ql8.py
Configuration 3 i.e mode 2 uses Ql2.py
Configuration 5 i.e mode 5 uses Ql5.py
Configuration 6 i.e mode 4 uses Ql467.py
Configuration 7 i.e mode 3 uses Ql3.py

for compressor compartment
It is considered in Qlxxx files by variable NCCTYPE.

NCCTYPE variable is calculated in QCtrl line 95-113

#-----------------------------------------------------------
# Job 			: Calculate cycle type according to Compressor Compartment dimentions. (common for all)
# Input 		: CCHGT : Compressor Compartment Height
#				  CDUP : Compressor Compartment Top Depth
# Output		:
#-----------------------------------------------------------
def set_ncctype (self):
	# this value is NA in mode 5
	if self.obj_data.NMOD == 5: return
	
	ncc_type = None
	if self.obj_data.CCHGT != 0.0:
		if self.obj_data.CDUP != 0.0:
			ncc_type =  3
		else:
			ncc_type =  2
	else:
		ncc_type = 1
	self.obj_data.NCCTYPE = ncc_type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants