Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: smart diffing #24

Open
ayoayco opened this issue Dec 13, 2023 · 0 comments · May be fixed by #40
Open

feat: smart diffing #24

ayoayco opened this issue Dec 13, 2023 · 0 comments · May be fixed by #40
Assignees
Milestone

Comments

@ayoayco
Copy link
Owner

ayoayco commented Dec 13, 2023

Currently, it's just very crude: we compare previous dom to incoming dom and if there is change, we wipe the whole children and replace.

We can detect changes and call specific DOM manipulation:

  1. if property = update property / set attribute
  2. if child = call diff on child
  3. if text node = replace text node
  4. etc.
@ayoayco ayoayco pinned this issue Dec 13, 2023
@ayoayco ayoayco unpinned this issue Dec 17, 2023
@ayoayco ayoayco self-assigned this Dec 24, 2023
@ayoayco ayoayco added this to the v3.0.0 milestone Dec 24, 2023
This was referenced Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant