feat: smart diffing #40
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ayoayco
commented
Dec 25, 2023
| import { createElement, handleProp } from "./utils/index.js"; | ||
|
|
||
| export function render(template, host) { | ||
| if (!host.__prev_watch_list__) { |
There was a problem hiding this comment.
We can combine this check in line 15 🤔
| ? (f(), (t = 2)) | ||
| : (u += e)), | ||
| 3 === t && "!--" === u && ((t = 4), (o = o[0])); | ||
| var n = function (t, s, r, e) { |
There was a problem hiding this comment.
check if htm/mini is okay to bring back
| this.onChanges({ property, previousValue, currentValue }); | ||
| } | ||
| } | ||
|
|
||
| #handleUpdateProp(key, stringifiedValue) { | ||
| const restored = deserialize(stringifiedValue, this.#typeMap[key]); | ||
| if (restored !== this.props[key]) this.props[key] = restored; |
| @@ -111,15 +111,17 @@ export class WebComponent extends HTMLElement { | |||
| this[camelCaps] = this[property]; | |||
|
|
|||
| this.#handleUpdateProp(camelCaps, this[property]); | |||
|
|
|||
| const newNode = | ||
| change.type === "replace" ? change.node?.parentNode : change.node; | ||
|
|
||
| if (newNode instanceof Node) { |
There was a problem hiding this comment.
Check is child is in parent 🤔
| @@ -1,44 +1,82 @@ | |||
| import { serialize } from "./serialize.mjs"; | |||
| export function createElement(tree) { | |||
| export function createElement(tree, watchList = []) { | |||
| @@ -1,44 +1,82 @@ | |||
| import { serialize } from "./serialize.mjs"; | |||
| export function createElement(tree) { | |||
| export function createElement(tree, watchList = []) { | |||
There was a problem hiding this comment.
Require watchList and remove default
|
|
||
| function h(type, props, ...children) { | ||
| return { type, props, children }; | ||
| const r = { type, props, children }; | ||
| return r; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Mark dynamic DOM (lookout for tree === false)
Comment on lines
+71
to
+74
| } else if (prop in el) { | ||
| el[prop] = value; | ||
| } else if (domProp in el) { | ||
| el[domProp] = value; |
There was a problem hiding this comment.
See if setAttribute is enough. Look out for
- class & className
- for
- onclick & onClick
| "include": [ | ||
| "src/*", | ||
| "src/utils/*", | ||
| "src/render.js", |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24
This implements diffing by
Left todo