Make OkHttp coroutine calls always throw exceptions on errors

Author: az4521

app/src/main/java/eu/kanade/tachiyomi/data/updater/devrepo/DevRepoUpdateChecker.kt

@@ -26,7 +26,7 @@ class DevRepoUpdateChecker : UpdateChecker() {
 
     override suspend fun checkForUpdate(): UpdateResult {
         val response = withContext(Dispatchers.IO) {
-            client.newCall(GET(DevRepoRelease.LATEST_URL)).await(assertSuccess = false)
+            client.newCall(GET(DevRepoRelease.LATEST_URL)).await()
         }
 
         // Get latest repo version number from header in format "Location: tachiyomi-r1512.apk"

app/src/main/java/eu/kanade/tachiyomi/network/OkHttpExtensions.kt

@@ -64,11 +64,11 @@ fun Call.asObservableWithAsyncStacktrace(): Observable<Pair<Exception, Response>
 fun Call.asObservable() = asObservableWithAsyncStacktrace().map { it.second }
 
 // Based on https://github.com/gildor/kotlin-coroutines-okhttp
-suspend fun Call.await(assertSuccess: Boolean = false): Response {
+suspend fun Call.await(): Response {
     return suspendCancellableCoroutine { continuation ->
         enqueue(object : Callback {
             override fun onResponse(call: Call, response: Response) {
-                if (assertSuccess && !response.isSuccessful) {
+                if (!response.isSuccessful) {
                     continuation.resumeWithException(Exception("HTTP error ${response.code}"))
                     return
                 }