Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Herbalism] don't remove Lifeblood #17

Open
r0m1ntik opened this issue Feb 23, 2021 · 3 comments
Open

[Herbalism] don't remove Lifeblood #17

r0m1ntik opened this issue Feb 23, 2021 · 3 comments

Comments

@r0m1ntik
Copy link

On remove profession Herbalism , Lifeblood not removed.

in

void Player::SetSkill(uint32 id, uint16 step, uint16 newVal, uint16 maxVal)

Remove if have first rank, but have just (rank 6)

// remove all spells that related to this skill
for (uint32 j = 0; j < sSkillLineAbilityStore.GetNumRows(); ++j)
    if (SkillLineAbilityEntry const* pAbility = sSkillLineAbilityStore.LookupEntry(j))
        if (pAbility->SkillLine == id)
            RemoveSpell(sSpellMgr->GetFirstSpellInChain(pAbility->Spell));
@r0m1ntik
Copy link
Author

@Helias

@Helias
Copy link
Member

Helias commented Feb 23, 2021

You're right.
We should make a PR for it

@IntelligentQuantum
Copy link
Member

IntelligentQuantum commented Sep 17, 2021

In fact, we have to fix the unlearn profession in the source, The learning and unlearning system in AC does not work properly.
And that this problem occurred in the new update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants