Skip to content
This repository has been archived by the owner on Aug 18, 2022. It is now read-only.

Rover v2 Implementation - Proposal #4

Open
benc-uk opened this issue May 24, 2021 · 2 comments
Open

Rover v2 Implementation - Proposal #4

benc-uk opened this issue May 24, 2021 · 2 comments
Labels
Milestone

Comments

@benc-uk
Copy link
Collaborator

benc-uk commented May 24, 2021

This issue is to discuss & provide feedback on the proposal for Rover v2, which is hosted on the wiki for easier editing

📝 Rover v2 Draft Proposal

Note. This is a "living document" and constantly evolving

@benc-uk benc-uk added this to the planning milestone May 24, 2021
@benc-uk benc-uk self-assigned this May 26, 2021
@benc-uk benc-uk changed the title Map out top level commands & sub commands Design and propose level commands & sub commands May 26, 2021
@benc-uk benc-uk changed the title Design and propose level commands & sub commands Design and propose command structure & CLI shape May 26, 2021
@benc-uk benc-uk added the rover-go Reimplement rover in Go label May 27, 2021
@benc-uk benc-uk changed the title Design and propose command structure & CLI shape Rover v2 / Go Implementation - Proposal Jun 3, 2021
@benc-uk
Copy link
Collaborator Author

benc-uk commented Jun 3, 2021

Agreements from meeting 3rd Jun

  • All authentication is deferred to the Azure CLI (and the auth token it maintains), env vars (e.g. ARM_CLIENT_ID) are not used except in the impersonation scenario
  • This will be a clean break and a v2 of rover CLI, it will not be backwards compatible, but some migration guide, i.e. mapping old command to new will be written
  • The landingzone and launchpad modes will be split into separate top level commands (as it currently is)
  • The rover cd command and use of a symphony YAML config is expected to be the main use case going forward
  • The rover launchpad and rover landingzone will be kept for people wishing to test locally and personas not doing devops (IT pros etc). The cd, launchpad and landingzone commands will all function on the same code under the hood, where they source their inputs from is all that differs (flags vs config file)

@benc-uk benc-uk pinned this issue Jun 3, 2021
@benc-uk benc-uk changed the title Rover v2 / Go Implementation - Proposal Rover v2 Implementation - Proposal Jun 3, 2021
@benc-uk
Copy link
Collaborator Author

benc-uk commented Jun 7, 2021

7th June

  • Agreed to move the --action flag to be a sub-command of launchpad, landingzone and cd
  • Agreed on symmetry between all three commands
  • Agreed CD should look for default config file name in current directory

@benc-uk benc-uk removed their assignment Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant