Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove BoundingBox2D message #4

Open
minhnh opened this issue May 28, 2019 · 2 comments
Open

remove BoundingBox2D message #4

minhnh opened this issue May 28, 2019 · 2 comments
Assignees
Labels
Status: Stale The PR or issue has been abandoned.

Comments

@minhnh
Copy link
Member

minhnh commented May 28, 2019

As there exists the message sensor_msgs/RegionOfInterest, we should remove our mas_perception_msgs/BoundingBox2D in favor of the built-in option.

This will affect mas_perception_msgs/Plane, and potentially mdr_place_action, since it uses the limits field in mas_perception_msgs/Plane of type mas_perception_msgs/BoundingBox2D.

Since the values from this limits can be calculated from the convex_hull field which contains 3D points, I think it's ok to simply remove limits as the plane may not always be horizontal.

@alex-mitrevski
Copy link
Member

I suppose we could take a look at this on Friday.

@stale
Copy link

stale bot commented Aug 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale The PR or issue has been abandoned. label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale The PR or issue has been abandoned.
Projects
None yet
Development

No branches or pull requests

2 participants