Fix: Rectified dialect check in ENRGetSystableScan function to also check for the conn_type (#632)

* Fix: Rectified dialect check in ENRGetSystableScan function to also
check for the conn_type

In ENRGetSystableScan, if the dialect is not TSQL_DIALECT and there is a
scan initiated for a catalog (other than Sequence), we return false i.e.
the tuple being scanned for does not exist in ENR. But this is not
reliable in case this scan is initiated from a PG function since the
dialect then would be PG_DIALECT and the scan in ENR would return false,
even though the actual tuple being searched for is in ENR (in case it's
a T-SQL temp table). This results in a "could not open a relation" error
since the tuple also does not exist in pg_catalog.

Task: BABEL-6099

Signed-off-by: Ayush Shah <[email protected]>

Author: ayushdsh

src/backend/utils/misc/queryenvironment.c

@@ -32,6 +32,7 @@
 #include "catalog/catalog.h"
 #include "catalog/dependency.h"
 #include "catalog/indexing.h"
+#include "catalog/namespace.h"
 #include "catalog/pg_authid.h"
 #include "catalog/pg_collation.h"
 #include "catalog/pg_opclass.h"
@@ -421,14 +422,22 @@ bool ENRGetSystableScan(Relation rel, Oid indexId, int nkeys, ScanKey key, List
 
 	Oid reloid = RelationGetRelid(rel);
 
-	if (sql_dialect != SQL_DIALECT_TSQL)
+	/*
+	 * We should allow ENR scans for T_SQL dialect as well as 
+	 * PG dialect from TDS endpoint. 
+	 * Because there are cases where dialect is set to temporarily to 
+	 * PG when executing PG functions and it tries to scan ENRs.
+	 *
+	 * Note: Due to this condition, scanning for ENR temp tables
+	 * from PG endpoint and in PG dialect will not work.
+	 */
+	if (sql_dialect != SQL_DIALECT_TSQL && !(is_bbf_tds_connection_hook && is_bbf_tds_connection_hook()))
 	{
 		/*
-		* We cannot return false right away when sql_dialect is not TSQL.
-		* There are cases when sql_dialect is temporarily set to PG when
-		* executing PG functions such as nextval_internal() in the case of
-		* identity sequence.
-		*/
+		 * There are cases when sql_dialect is temporarily set to PG when
+		 * executing PG functions such as nextval_internal() in the case of
+		 * identity sequence.
+		 */
 		if (reloid != SequenceRelationId)
 			return false;