Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change API to automatically use plural types #101

Open
backspace opened this issue Dec 9, 2018 · 0 comments
Open

Change API to automatically use plural types #101

backspace opened this issue Dec 9, 2018 · 0 comments

Comments

@backspace
Copy link
Owner

I tried to use a new feature of JaSerializer where it can generate plural types by default but got bogged down in mysterious seemingly-unrelated incompatibilities because of a new dependency on plug_cowboy. This is only happening because I bypassed Ember Data in the overlaps-checking and Mirage serialises with plural types but the API has singular types, which results in some ugly type-checking when sifting results. For now I’m manually overriding the relevant types (backspace/prison-rideshare-api@97982d9) but it would be nice to use this feature. Maybe I’ll have to update to Phoenix 1.4 or something…?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant