Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite pool file, if pool file is zero-length #19

Open
raoulbhatia opened this issue Jan 24, 2021 · 0 comments
Open

Rewrite pool file, if pool file is zero-length #19

raoulbhatia opened this issue Jan 24, 2021 · 0 comments

Comments

@raoulbhatia
Copy link

To my understanding, https://github.com/backuppc/rsync-bpc/blob/master/bpc_sysCalls.c#L784
has 2 reasons for rewriting a file

a) the file was removed from the pool
b) the file was marked for deletion and can be re-used.

I suggest to also rewrite if the pool file is zero-length. However, I am not able to understand the source code well enough to judge if chains / handling md5 collisions might play a role here.

Related to issues mentioned in backuppc/backuppc#412

Thanks,
Raoul

@raoulbhatia raoulbhatia changed the title Also rewrite file if file size is 0 Also rewrite file if pool file is zero-length Jan 24, 2021
@raoulbhatia raoulbhatia changed the title Also rewrite file if pool file is zero-length Also rewrite pool file, if pool file is zero-length Jan 24, 2021
@raoulbhatia raoulbhatia changed the title Also rewrite pool file, if pool file is zero-length Rewrite pool file, if pool file is zero-length Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant