Includes to accept expressions not just String literals

[obviam]

Consider the following code that iterates through a huge array of sections to include a list of generated files.

{{for section in sections}}
  <code>{{ include section.get_example_curl}}</code>
  <code>{{ include section.post_example_curl}}</code>
{{end}}

There only way to achieve it is to hardcode the path.

<code>{{ include "../target/generated-snippets/section1/get-example/curl-request.md"}}</code>
<code>{{ include "../target/generated-snippets/section1/post-example/curl-request.md"}}/code>
...
<code>{{ include "../target/generated-snippets/sectionX/get-example/curl-request.md"}}</code>
<code>{{ include "../target/generated-snippets/sectionX/post-example/curl-request.md"}}/code>

I haven't properly understood the code so far, but it looks like the Parser#parseInclude is the place to do it. I raised this issue as an improvement, as it's not really an issue.
If I come up with a solution I will do a PR if it gets accepted as an improvement.

[badlogic]

This could be useful, but is not a trivial change. Includes are applied before any code is executed. When a template is loaded, all its includes are (recursively) loaded before any code executes. Only allowing string literals makes it trivial, as we do not have to execute any code to evaluate the includes. It could still work if you modify the parseInclude method to expect an expression, and also modify the Include and Include abstract syntax tree nodes. They need to store an Expression, which is evaluated to a String when getPath() is called. The getPath() method would need to receive a context though, which could get very hairy.

…

On Mon, Jul 30, 2018, 5:11 PM Impaler ***@***.***> wrote: Consider the following code that iterates through a huge array of sections to include a list of generated files. {{for section in sections}} <code>{{ include section.get_example_curl}}</code> <code>{{ include section.post_example_curl}}</code> {{end}} There only way to achieve it is to hardcode the path. <code>{{ include "../target/generated-snippets/section1/get-example/curl-request.md"}}</code> <code>{{ include "../target/generated-snippets/section1/post-example/curl-request.md"}}/code> ... <code>{{ include "../target/generated-snippets/sectionX/get-example/curl-request.md"}}</code> <code>{{ include "../target/generated-snippets/sectionX/post-example/curl-request.md"}}/code> I haven't properly understood the code so far, but it looks like the Parser#parseInclude is the place to do it. I raised this issue as an improvement, as it's not really an issue. If I come up with a solution I will do a PR if it gets accepted as an improvement. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAfYBOsX_CyDdhHlQtKntTtoDD6m5aFrks5uLyICgaJpZM4VmmHR> .

[obviam]

It's not trivial indeed and thanks for the pointers. It's a rare use-case, so have to weight that in.